Skip to content

GH-47469: [C++][Gandiva] Add support for LLVM 21.1.0#47473

Merged
kou merged 2 commits intoapache:mainfrom
raulcd:GH-47469
Sep 2, 2025
Merged

GH-47469: [C++][Gandiva] Add support for LLVM 21.1.0#47473
kou merged 2 commits intoapache:mainfrom
raulcd:GH-47469

Conversation

@raulcd
Copy link
Copy Markdown
Member

@raulcd raulcd commented Sep 2, 2025

Rationale for this change

LLVM 21.1 was released and some of our CI jobs are failing.

What changes are included in this PR?

  • Accept LLVM 21.1
  • Don't use deprecated API

Two of the related commits that changed APIs on LLVM are:

Are these changes tested?

Yes on CI

Are there any user-facing changes?

No

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2025

⚠️ GitHub issue #47469 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented Sep 2, 2025

@github-actions crossbow submit -g cpp

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 2, 2025

Revision: c0e329e

Submitted crossbow builds: ursacomputing/crossbow @ actions-e1bf7ac3c1

Task Status
example-cpp-minimal-build-static GitHub Actions
example-cpp-minimal-build-static-system-dependency GitHub Actions
example-cpp-tutorial GitHub Actions
test-build-cpp-fuzz GitHub Actions
test-conda-cpp GitHub Actions
test-conda-cpp-valgrind GitHub Actions
test-cuda-cpp-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-debian-12-cpp-amd64 GitHub Actions
test-debian-12-cpp-i386 GitHub Actions
test-fedora-42-cpp GitHub Actions
test-ubuntu-22.04-cpp GitHub Actions
test-ubuntu-22.04-cpp-20 GitHub Actions
test-ubuntu-22.04-cpp-bundled GitHub Actions
test-ubuntu-22.04-cpp-emscripten GitHub Actions
test-ubuntu-22.04-cpp-no-threading GitHub Actions
test-ubuntu-24.04-cpp GitHub Actions
test-ubuntu-24.04-cpp-bundled-offline GitHub Actions
test-ubuntu-24.04-cpp-gcc-13-bundled GitHub Actions
test-ubuntu-24.04-cpp-gcc-14 GitHub Actions
test-ubuntu-24.04-cpp-minimal-with-formats GitHub Actions
test-ubuntu-24.04-cpp-thread-sanitizer GitHub Actions

Copy link
Copy Markdown
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's wait for CI

@raulcd
Copy link
Copy Markdown
Member Author

raulcd commented Sep 2, 2025

The CPP Valgrind failure is unrelated and seems to have been around for a while. I've opened an issue as I don't think it's tracked anywhere:

Copy link
Copy Markdown
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Thanks!

@kou kou merged commit 57b4b4b into apache:main Sep 2, 2025
36 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Sep 2, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Sep 2, 2025
@conbench-apache-arrow
Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 57b4b4b.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

@dmitry-chirkov-dremio
Copy link
Copy Markdown
Contributor

Thank you for this, Raúl.
We were just trying to unpack why our macOS builds are falling back to 15.0.7 and not using whatever Brew is installing - I think it's was the lack of new available LLVM versions in ARROW_LLVM_VERSIONS.

lriggs pushed a commit to lriggs/arrow that referenced this pull request Oct 8, 2025
)

LLVM 21.1 was released and some of our CI jobs are failing.

* Accept LLVM 21.1
* Don't use deprecated API

Two of the related commits that changed APIs on LLVM are:
- llvm/llvm-project@034f2b3
- llvm/llvm-project@b18e5b6

Yes on CI

No

* GitHub Issue: apache#47469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
lriggs pushed a commit to lriggs/arrow that referenced this pull request Oct 9, 2025
)

LLVM 21.1 was released and some of our CI jobs are failing.

* Accept LLVM 21.1
* Don't use deprecated API

Two of the related commits that changed APIs on LLVM are:
- llvm/llvm-project@034f2b3
- llvm/llvm-project@b18e5b6

Yes on CI

No

* GitHub Issue: apache#47469

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants